[Mplayer-cvslog] CVS: main/postproc swscale.c,1.91,1.92 swscale_template.c,1.78,1.79

[Nick Kurshev]

Hello, Michael!

On Mon, 24 Jun 2002 20:31:59 +0200 you wrote:

> Hi
> 
> On Monday 24 June 2002 20:15, Nick Kurshev wrote:
> [...]
> > > -#define isBGR(x)       ((x)==IMGFMT_BGR32|| (x)==IMGFMT_BGR24||
> > > (x)==IMGFMT_BGR16|| (x)==IMGFMT_BGR15) 
> > > -#define isRGB(x)      
> > > ((x)==IMGFMT_RGB32|| (x)==IMGFMT_RGB24|| (x)==IMGFMT_RGB16||
> > > (x)==IMGFMT_RGB15) 
> > > -#define isPlanarYUV(x) ((x)==IMGFMT_YV12 ||
> > > (x)==IMGFMT_I420 || (x)==IMGFMT_IYUV|| (x)==IMGFMT_YVU9 ||
> > > (x)==IMGFMT_IF09) 
> > > -#define isYUV(x)       (!(isBGR(x) || isRGB(x)))
> > > -#define isHalfChrV(x)  ((x)==IMGFMT_YV12 || (x)==IMGFMT_I420 ||
> > > (x)==IMGFMT_IYUV) 
> > > +#define isPlanarYUV(x) ((x)==IMGFMT_YV12 ||
> > > (x)==IMGFMT_I420 || (x)==IMGFMT_YVU9) 
> > > +#define isYUV(x)      
> > > ((x)==IMGFMT_YUY2 || isPlanarYUV(x))
> >
> > I really don't understand why you've ignored other packed foourccs.
> > IMHO my version was (is in mplayerxp) better
> code like "#define isYUV(x)       (!(isBGR(x) || isRGB(x)))"
> is very dirty, and simply wrong (Y800, BGR8, ...) are wrongly identified as 
> yuv
Y800 is YUV and even more it's planar_yuv fourcc which has behaviour of packed fourcc.
> and the swscaler currently simply doesnt support other packed formats except 
> these so it makes no sense to check for them
> 
scaler - maybe but not blitter
> >
> > > +#define isHalfChrV(x)  ((x)==IMGFMT_YV12 || (x)==IMGFMT_I420)
> >
> > What about everything which was below - I use swScaler as universal blitter
> > )in my dri_vo output) and have tuned many things which were destroyed by
> > your commit.
> could u be more specific?
Sorry! For mplayer it doesn't matter. It matters only for mplayerxp.
It uses only one vo_driver (so-called video_out.c). Everything other
are plugins which provide only surface properties' description.
But driver always calls swScaler to perform plane to plane
blitting/convertion/scaling (depends on src and dest w,h,fourcc).
> 
> [...]
> 
> Michael
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
> 


Best regards! Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20020625/16e00a32/attachment.pgp>