[Mplayer-cvslog] CVS: main/libmpdemux open.c,1.50,1.51

[Arpi]

Hi,

> >         open.c
> > Log Message:
> > There appears to be a trivial namespace error in determining the valid
> > chapter range.  It appears that "dvd_title" should be used with
> > tt_srpt->title[], and "ttn-1" should be used with
> > vts_file->vts_ptt_srpt->title[].
> > patch by Dave Sainty <dave at dtsp.co.nz>
> I'm not totally sure about this, it could aswell be mastering errors of the 
> dvd, as on many dvds ttn-1 and dvd_title were always the same, but on some 
> eg. SW EP1, they sometimes differed. However I now used the modified version 
> for some time (with dvd_title) and had no problems so far, so lets keep it 
> for now with dvd_title.

yes, i also had doubt, but after 30 mins of reading the source, and .h
files, i've found that he is right. all other use of tt_srpt->title[] was
with dvd_title, and all other use of vts_file->vts_ptt_srpt->title[] use
ttn-1. so, his fix is trivial and right.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu