[Mplayer-cvslog] UNAPPLIED PATCHES?

[Diego Biurrun]

Arpi writes:
 > >  The FFmpeg project provides libavcodec, a very portable MPEG4/DivX codec with
 > it's not only mpeg4/divx

Point taken, but this was there before.

 > > -excellent speed and quality.  It is the preferred codec of MPlayer for playing
 > > -mpeg4 and divx video.  You have to get libavcodec directly from the FFmpeg CVS
 > > -server. Use the following commands in a suitable directory outside the MPlayer
 > > -source directory:
 > > +excellent speed and quality. It is the preferred MPEG4/DivX codec of MPlayer
 > > +and used to be included in the MPlayer CVS tree.  This is no longer the case
 > > +and you have to get libavcodec directly from the FFmpeg CVS server.
 > 
 > why do you bring that most discussed 'used to be included in cvs' thingie
 > back???

This is not meant to restart the discussion.  It's just that we tell
the user to check if the dir is empty, replace it and do all kinds of
weird stuff with it.  That person will surely wonder why.  This is
just a historical note to answer this question, it does after all keep
reappearing on -users.

If you don't like it, I can remove it, of course, but I don't think a
little bit of background info will hurt.

 > > -cvs -z9 -d:pserver:anonymous at cvs.ffmpeg.sourceforge.net:/cvsroot/ffmpeg co ffmpeg/libavcodec
 > > +cvs -z3 -d:pserver:anonymous at cvs.ffmpeg.sourceforge.net:/cvsroot/ffmpeg co ffmpeg/libavcodec
 > 
 > -z9 is better compression, don't change this

I know.  The different compression levels z1-z9 have different CPU
usage / compression ratio tradeoff.  z9 is very CPU intensive and we
generally recommend z3 in other parts of the documentation.  Besides
this was taken directly from the FFmpeg CVS page:

http://sourceforge.net/cvs/?group_id=16082

They recommend z3 there.  I believe that if we include instructions to
access external projects we should honor their choice of options,
since they probably put it there to make optimal use of their
available CPU and bandwidth.

 > > -While MPlayer and libavcodec has built-in support for the most common audio
 > > -and video formats, some others are playable only with the Win32 DLLs
 > > -or the XAnim binary plugins. Few examples: WMV video, Divx/WMA audio, Indeo.
 > > -This step is not mandatory, but recommended for getting MPlayer to play more
 > > -different file types!
 > > -
 > > -Grab the win32 codecs package from the download page
 > > -
 > > -  http://www.mplayerhq.hu/homepage/dload.html
 > > +MPlayer and libavcodec have builtin support for the most common audio and video
 > > +formats, but some others are playable only with the Win32 DLLs or the XAnim
 > > +binary plugins. Examples include WMV video, DivX with WMA audio (not normal
 > 
 > this wma thing was also discussed earlier
 > 
 > please don't bring old things back we voted out already

???  I'm not bringing back anything here.  I just reworded the
section:

  While MPlayer and libavcodec has built-in support for the most
  common audio and video formats, some others are playable only with
  the Win32 DLLs or the XAnim binary plugins. Few examples: WMV video,
  Divx/WMA audio, Indeo.

-->

  MPlayer and libavcodec have builtin support for the most common
  audio and video formats, but some others are playable only with the
  Win32 DLLs or the XAnim binary plugins. Examples include WMV video,
  DivX with WMA audio (not normal

 > > -To enable OSD (onscreen status display) and ASCII/TEXT subtitles you need some
 > > -fonts. Get them from our homepage:
 > > +Unpack the archive and choose one of the available font sizes. Then copy the
 > > +font files of the corresponding size into /usr/local/share/mplayer/font/ or
 > > +~/.mplayer/font/ (or whatever you set with './configure --datadir=DIR').
 > >  
 > > -http://www.mplayerhq.hu/homepage/dload.html
 > > -
 > > -Unpack the archive and choose one of the available font sizes.  Then copy the
 > > -font files of the corresponding size into /usr/local/share/mplayer/font/
 > > -(or whatever you set with './configure --datadir=DIR').
 > >  
 > why did you removed explanation?

I moved it to step0, but this could be made a little more clear in
step0, I'll update that.

 > > -Please remember that the GUI is still in the alpha development stage and not
 > > -completely finished yet. Features like playlist, preferences and equalizer
 > > -do not work at all. Expect them for the 1.0 release
 > > -Basic stuff like file selection and seeking works, though.
 > 
 > same here

I moved it to the first paragraph.  The GUI in the alpha development
stage was mentioned there anyway, so why explain the details two pages
later?  This way the installation instructions are less cluttered and
the explanation at the beginning is more complete.

 > > +  mplayer -gui <moviefile>
 > why +?

gmplayer is created by make install, so it will not be available if
people just run make and start playing around with mplayer.  I, for
example, do not have mplayer installed.  I install the latest release
as Debian package, but nearly always start latest CVS from its
absolute path.  -gui does always work, so I thought it would not hurt
to mention it.  Besides you apparently cannot use gmplayer with gdb
because it is a symlink, this surfaced on -users some time ago:

http://www.mplayerhq.hu/pipermail/mplayer-users/2002-June/017431.html

 > >    gmplayer <moviefile>
 > > -  (just 'gmplayer' is enough to use the GUI fileselector)
 > why -?

Still there, slightly reworded, one line below:

  Without <moviefile>, MPlayer will come up and you will be able to
  use the GUI filepicker.

 > your patch has nice parts but mostly bad changes
 > i'll manually merge good things from it, don't commit.

I made an updated one with your suggestions included.
Thanks for your input

Diego


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mplayer_readme.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20020705/52839cd7/attachment.asc>