[Mplayer-cvslog] CVS: main/vidix/drivers mga_vid.c,1.13,1.14

[Nick Kurshev]

Hello, Alex!

On Mon, 1 Jul 2002 12:07:09 +0200 you wrote:

> Hi,
> 
> > > Index: mga_vid.c
> > > ===================================================================
> > > RCS file: /cvsroot/mplayer/main/vidix/drivers/mga_vid.c,v
> > > retrieving revision 1.13
> > > retrieving revision 1.14
> > > diff -u -r1.13 -r1.14
> > > --- mga_vid.c	2 Feb 2002 18:28:55 -0000	1.13
> > > +++ mga_vid.c	29 Jun 2002 11:40:28 -0000	1.14
> > > @@ -6,14 +6,12 @@
> > >      YUY2 support (see config.format) added by A'rpi/ESP-team
> > >      double buffering added by A'rpi/ESP-team
> > >  
> > > -    Brightness/contrast support by Nick Kurshev
> > > +    Brightness/contrast support by Nick Kurshev/Dariush Pietrzak (eyck) and me
> > Do yo guess that users should track cvslog to know who is 'me'? :)
> Nom but at the beginning of the file there's 'ported to VIDIX by Alex Beregszaszi',
> and that's the copyright, so 'me' should be easily guessed
> 
> Also feel free to commit this into mpxp, i will fix the remaining two bugs
Already done.
> in vidix mga_vid. (doublebuffer support and resize-0x0-segfault-bug;)
> 
For mpxp it would be much better to improve this driver in xp way.
int vixConfigPlayback(vidix_playback_t *config)
{
...
    if ((config->num_frames < 1) || (config->num_frames > 4))
    {
	printf("[mga] illegal num_frames: %d, setting to %d\n",
	    config->num_frames, MGA_DEFAULT_FRAMES);
	config->num_frames = MGA_DEFAULT_FRAMES;
...
    config->offsets[0] = 0;
    config->offsets[1] = config->frame_size;
    config->offsets[2] = 2*config->frame_size;
    config->offsets[3] = 3*config->frame_size;
    
XP mode requires from 5 upto 64 buffers.
Thus this driver is not ready for mpxp in general.
> -
> alex
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
> 


Best regards! Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20020702/1d03e8a8/attachment.pgp>