[Mplayer-cvslog] CVS: main configure,1.393,1.394 Makefile,1.158,1.159

[pl]

Hi Nick,

On Mon, Feb 25, 2002 at 06:14:42PM +0300, Nick Kurshev wrote:
...
> > > RCS file: /cvsroot/mplayer/main/configure,v
> > > retrieving revision 1.393
> > > retrieving revision 1.394
> > ...
> > > @@ -498,7 +506,7 @@
> > >  }
> > >  EOF
> > >    $_cc -o "$TMPO" "$TMPC"
> > > -  case `"$TMPO"` in
> > > +  case "$TMPO" in
> > >      0-0) proc="ev4" ;;
> > >      1-0) proc="ev5" ;;
> > >      1-1) proc="ev56" ;;
> > ...
> > 
> > This hunk does not seem correct as the test wants the output result of
> > the compiled program - not its name.

> Then why midnight shows this file in black?
FWIW vim has also sometimes troubles with coloring weird yet valid shell
patterns. (if midnight is what I believe it to be)

> In other places there are "" only and it seems enough!
> But I could be wrong,

Other places are most likely to be results already computed but here,
it's evaluated on the fly.

TMPO is a filename of a binary application that writes to stdout.

FYI, see the differents effects of: 
1) case  "hostname"  in hostname) echo foo ;; *) echo bar ;; esac   => foo
2) case   hostname   in hostname) echo foo ;; *) echo bar ;; esac   => foo
3) case  `hostname`  in hostname) echo foo ;; *) echo bar ;; esac   => bar
4) case `"hostname"` in hostname) echo foo ;; *) echo bar ;; esac   => bar

We had 4 and it was changed in 1.

If TMPO does not contain spaces (which is assumed in most places), 1==2 and 3==4.
If TMPO contains spaces, the 4 cases are different.

If it were a: if "$TMPO" ; ... fi construction, it would be fine as TMPO
would be evaluated. That's why you'll often see if test "$_x11" ; ...

Hmmm... not sure I was crystal-clear 8)

-- 
Best regards,
  pl