[Mplayer-cvslog] CVS: main mplayer.c,1.471,1.472 playtree.c,1.12,1.13

[Alban Bedel]

Hi Zoltan Ponekker,

on Tue, 16 Apr 2002 19:41:31 +0200 you wrote:

> Update of /cvsroot/mplayer/main
> In directory mplayer:/var/tmp.root/cvs-serv24907
> 
> Modified Files:
> 	mplayer.c playtree.c 
> Log Message:
> fix playlist bug with gui and rewrite mousecursor show/hide code
Should be : fix GUI bug with a bad hack in playtree code !

>  play_tree_iter_step(play_tree_iter_t* iter, int d,int with_nodes) {
>    play_tree_t* pt;
>  
> +  if ( !iter ) return PLAY_TREE_ITER_ENTRY;
> +  if ( !iter->root ) return PLAY_TREE_ITER_ENTRY;
> +  

Please stop doing these things. It have NO SENSE AT ALL to call this function with 
iter == NULL !!!
Check your code please. You did the same with mp_cmd_free, why ? To be able to
write mp_cmd_free(NULL) or play_tree_iter_step(NULL,0,0) ? It's stupid, check 
YOUR CODE. If you need them write a warper or whatever you want but don't put this
here.

PS: I don't want to be offencive but I'm fed up with this. It's not the first time you write
	in cvs log/code that you add/remove a workaround for a bug in the playtree code
	when it's a bug in your code. If you need some help with playtree and such, just
	ask and stop ranting (or worse adding stupid "workaround") because you don't 
	understand how it work.

		Albeu