[Mplayer-cvslog] CVS: main/postproc rgb2rgb.c,1.22,1.23 rgb2rgb.h,1.9,1.Mon Nov 5 14:12:12 2001

[Arpi]

Hi,

> >
> > -		((uint16_t *)dst)[i]= (b>>3) | ((g&0xFC)<<3) | ((r&0xF8)<<8);
> > +		*((uint16_t *)dst) = (b>>3) | ((g&0xFC)<<3) | ((r&0xF8)<<8);
> > +		dst+=2;
> > +		s++;
> >  	}
> >  }
> this is inacceptable, it is harder to read and very likely slower (arrays 
> tend to be faster than pointers)
> 
> did u try a -benchmark? if not than please reverse this change

Agree. i've reversed Nick's last patch.


A'rpi / Astral & ESP-team

--
mailto:arpi at thot.banki.hu
http://esp-team.scene.hu