[MPlayer-advusers] [patch] slow menus

[Dominik 'Rathann' Mierzejewski]

On Sunday, 07 January 2007 at 12:39, Adam Sulmicki wrote:
> 
> Dominik 'Rathann' Mierzejewski wrote:
> 
> >And any cosmetic changes (like indentation changes) should sent in a 
> >separate patch. Please follow 
> >http://www.mplayerhq.hu/DOCS/tech/patches.txt
> 
> just curious.
> 
> the "cosmetic" changes are result of putting a bit of code into "else" 
> statement and thus nesting it one more level.
> 
> how in your opinnion I was supposed to do this?
> 
> first submit incorrect patch without indentation

Why would it be incorrect? Indentation is for humans. Compilers don't
care. The point is, with whitespace changes, it's more difficult for
a human to see the functional changes introduced by your patch.

> and then submit separate patch with would account for the else branch,
> and thus required identation?

Yes.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan