[MEncoder-users] Encoding with an EDL

[The Wanderer]

Olivier Rolland wrote:

> On 6/30/07, The Wanderer <inverseparadox at comcast.net> wrote:
> 
>> If you intend this as a sumbission to be included in MPlayer SVN,
>> you should post it to the development list according to the
>> guidelines in DOCS/tech/patches.txt
> 
> Ok, I'll post the patch on mplayer-dev-eng.

Sans [PATCH] tag, apparently, but doesn't look too bad otherwise IMO.

>> though please note that your patch contains some changes which I
>> believe are considered cosmetic (e.g. removing braces on lines not
>> otherwise changed), and will likely require modification on those
>> grounds before being committed.
> 
> Read the patch again, it does not contain cosmetic.

That depends on your definition of "cosmetic". For example:

> -        if (!frame_data->already_read) { // when called after fixdelay, a frame is already read
> -            frame_data->in_size = video_read_frame(sh_video, &frame_data->frame_time, &frame_data->start, force_fps);
> -            if(frame_data->in_size<0) return 2;
> -            sh_video->timer += frame_data->frame_time;
> -        }
> +        if (!frame_data->already_read) // when called after fixdelay, a frame is already read
> +            if (!read_video(sh_video,frame_data)) return 2;

It would be possible to achieve exactly the same functional change
without either modifying the first line (removing the open-curly-brace
from before the comment) or removing the line which consists solely of a
close-curly-brace. Therefore, I believe that the changes to those lines
would be considered cosmetic. (It might be desired to make the changes
anyway, but not in the same patch as the one which makes the functional
change.)

However, the final decision on that matter will be made by the people
who have authority to reject or approve the patch itself; I just wanted
to mention the possibility.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.