[MEncoder-users] ./configure ignores --extra-libs= while checking for features

Moritz Barsnick barsnick at gmx.net
Mon Aug 6 18:28:23 CEST 2007


Hi,

due to some peculiar behavior, I noticed that ./configure is missing
the proper use of --extra-libs= during feature check.

The function compile_check() passes the flags from the variables
$_libs_mplayer and $_libs_mencoder to the compiler, but fails to do so
with $_extra_libs, which is a more generic equivalent of the two.

I had some libs explicitly stated with --extra-libs= (e.g. X11), but
compile_check() didn't pick these us, and therefore some checks failed.
(In my case it failed to pick up my specific X11 dir containing
libXv.so, and the created binary was linked with -lXv, but didn't have
the appropriate RPATH from my command line, so the binary refused to
execute.)

An easy, but I think correct, fix is attached.

(SVN r24015)

Thanks for listening. :)

Regards,
Moritz
-------------- next part --------------
--- configure.orig	2007-08-06 14:00:55.758640263 +0200
+++ configure	2007-08-06 14:02:23.720134644 +0200
@@ -62,9 +62,9 @@
   echo >> "$TMPLOG"
   cat "$1" >> "$TMPLOG"
   echo >> "$TMPLOG"
-  echo "$_cc $CFLAGS $_inc_extra $_ld_static $_ld_extra $_libs_mplayer $_libs_mencoder -o $TMPO $@" >> "$TMPLOG"
+  echo "$_cc $CFLAGS $_inc_extra $_ld_static $_ld_extra $_extra_libs $_libs_mplayer $_libs_mencoder -o $TMPO $@" >> "$TMPLOG"
   rm -f "$TMPO"
-  $_cc $CFLAGS $_inc_extra $_ld_static $_ld_extra $_libs_mplayer $_libs_mencoder -o "$TMPO" "$@" >> "$TMPLOG" 2>&1
+  $_cc $CFLAGS $_inc_extra $_ld_static $_ld_extra $_extra_libs $_libs_mplayer $_libs_mencoder -o "$TMPO" "$@" >> "$TMPLOG" 2>&1
   TMP="$?"
   echo >> "$TMPLOG"
   echo >> "$TMPLOG"


More information about the MEncoder-users mailing list