[FFmpeg-user] Reporting GCC 7.3.0 compiler-warnings on FFmpeg git (955fa23)

[Reino Wijnsma]

On 15-4-2018 15:16, Reino Wijnsma <rwijnsma at xs4all.nl> wrote:
> Hello ffmpeg-user(/devel),
>
> I've just compiled a fresh build from git (955fa23) (on Windows using Cygwin, MinGW and GCC).
> It compiled without errors, but I did get quite some warnings! I thought I'd share it with you.
> See the attached 'ffmpeg_build.log'.
On 16-4-2018 0:00, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote <https://ffmpeg.org/pipermail/ffmpeg-devel/2018-April/228297.html>:
> Attached patch is supposed to silence several user-reported warnings,
> I cannot currently test here.
>
> Please review, Carl Eugen
[...]
CC      libavcodec/dxva2.o
CC      libavcodec/dxva2_h264.o
CC      libavcodec/dxva2_hevc.o
CC      libavcodec/dxva2_mpeg2.o
CC      libavcodec/dxva2_vc1.o
CC      libavcodec/dxva2_vp9.o
[...]

On 16-4-2018 0:03, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote <https://ffmpeg.org/pipermail/ffmpeg-devel/2018-April/228299.html>:
> Attached patch is supposed to silence a user-reported warning, I
> cannot currently test.
>
> libavdevice/vfwcap.c: In function 'vfw_read_header':
> libavdevice/vfwcap.c:331:35: warning: passing argument 1 of 'av_parse_video_size' from incompatible pointer type [-Wincompatible-pointer-types]
>          ret = av_parse_video_size(&bi->bmiHeader.biWidth, &bi->bmiHeader.biHeight, ctx->video_size);
>                                    ^
>
> Please review, Carl Eugen
[...]
CC      libavdevice/vfwcap.o
[...]

On 16-4-2018 0:19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote <https://ffmpeg.org/pipermail/ffmpeg-devel/2018-April/228300.html>:
> rtmpe_write() exploits knowledge about av_rc4_crypt() internals and
> passes the same
> pointer as src and dst. I assume this is intentional for performance
> reasons, the only
> way to silence the resulting warning is a cast afaict.
>
> Please comment, Carl Eugen
[...]
CC      libavformat/rtmpcrypt.o
[...]

On 16-4-2018 1:33, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote <https://ffmpeg.org/pipermail/ffmpeg-devel/2018-April/228305.html>:
> Attached patch is supposed to silence a user-reported warning when
> inet_aton() is missing but getaddrinfo() is supported.
> Untested.
>
> Please review, Carl Eugen
[...]
CC      libavformat/os_support.o
libavformat/os_support.c: In function 'ff_poll':
libavformat/os_support.c:248:23: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
         if (fds[i].fd < 0)
                       ^
[...]

As you can see, no more warnings. Good job. Thanks. (The 'os_support.o'-warning above wasn't the warning that Carl fixed)

-- Reino