Hi<br><br><div><span class="gmail_quote">On 7/17/07, <b class="gmail_sendername">Michael Niedermayer</b> <<a href="mailto:michaelni@gmx.at">michaelni@gmx.at</a>> wrote:</span> <br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> #define FXQ(v) (roundf(16384.0*v)/16384.0)<br>> +#ifndef PI<br>> +#define PI 3.141592653<br>> +#endif<br><br>common.h gurantees existence of a M_PI</blockquote><div><br>Fixed already, thanks. <br></div><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> + {<br>> + av_log(NULL, AV_LOG_ERROR, "Error can't pitch cdn_vector[%d]\n",
<br>> + is_ifq);<br><br>please provide av_log() with a non null context</blockquote><div><br><br>Sure, consider those msgs just placeholders by now, I'm going to rework and<br>fix most of them while working on the decoder glue-code, I'll keep this in mind.
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">also<br><br>av_log(NULL, AV_LOG_ERROR, "Error can't pitch cdn_vector[%d]\n",
<br> is_ifq);<br><br>or<br><br>av_log(NULL,<br> AV_LOG_ERROR,<br> "Error can't pitch cdn_vector[%d]\n",<br> is_ifq);<br><br>is more readable if you cant put it all on one line</blockquote>
<div><br>Ok, will fix. Sometimes I go too far with my wrapalergy :) <br><br>Thanks for your comments.<br> <br>Reynaldo<br></div></div><br>