[FFmpeg-soc] [PATCH] AMR-WB Decoder

[Ronald S. Bultje]

Hi,

On Mon, Sep 6, 2010 at 5:54 AM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> On 09/06/2010 02:46 AM, Marcelo Galvão Póvoa wrote:
>> Ok, fortunately I've found the bug!
>>
>> It was just a MIN_ISF_SPACING parameter which I extracted from the
>> reference code but was unsure about it's Q level. After some time, I
>> thought I have it figured out but I was wrong. Now I know the answer
>> the hard way...
>>
>> The clipping and the sharp peaks are gone, the waveforms are really
>> close now!
>
> That's great news!
>
>> Also, the stddev against the reference decoder decreased a
>> lot (it was ~884 before):
>> all_men.awb stddev:   51.72 PSNR: 62.05 MAXDIFF: 1089 bytes:   473600/
>> 473600
>
> stddev of 51 looks pretty good to me for this case.

Maxdiff of 1089 looks like a lot to me, with a low stddev that
suggests that one particular part is off. Can you trace which part is
off and why (phase shift vs. actual bug)?

Ronald