[FFmpeg-soc] [PATCH 4/9] cosmetics: rename some fields in AC3EncodeContext

Ronald S. Bultje rsbultje at gmail.com
Mon Nov 15 22:50:33 CET 2010


Hi Justin,

On Mon, Nov 15, 2010 at 9:41 PM, Justin Ruggles
<justin.ruggles at gmail.com> wrote:
> Ronald S. Bultje wrote:
>> On Sun, Nov 14, 2010 at 8:43 PM, Justin Ruggles
>> <justin.ruggles at gmail.com> wrote:
>>> ---
>>>  libavcodec/ac3enc.c |   86 +++++++++++++++++++++++++-------------------------
>>>  1 files changed, 43 insertions(+), 43 deletions(-)
>> [..]
>>> @@ -49,14 +49,14 @@ typedef struct AC3EncodeContext {
>>>      int bits_written;
>>>      int samples_written;
>>>
>>> -    int nb_all_channels;
>>> -    int nb_channels;
>>> -    int lfe;
>>> -    int lfe_channel;
>>> +    int fbw_channels;
>>> +    int channels;
>>> +    int lfe_on;
>>> +    int lfe_ch;
>>
>> I actually like lfe_channel more...
>
> I changed it to match what is in ac3dec.  But I can change both...

Whatever others like, I suppose. Don't forget, you're maintainer, you
can ignore me at your wish. :-).

Ronald


More information about the FFmpeg-soc mailing list