[FFmpeg-soc] [PATCH] factor out writing rtsp headers

Martin Storsjö martin at martin.st
Sat May 29 11:13:20 CEST 2010


On Sat, 29 May 2010, Josh Allmann wrote:

> $subj, this may not be needed for RTSP over HTTP (depending on how I
> do it), but I think this patch cleans up the code a bit regardless.

The change itself looks ok, but I'm not certain that it's needed. You can 
keep it in your git tree and see later if you actually need it or not. On 
the other hand, if Ronald or Luca find this change desireable we could 
apply it straight away anyway.

> Messy diff though; all I did was factor out a hunk of code to a
> separate function, but old and new lines are interleaved here. My
> git-fu is weak; if there's a command to make a cleaner diff (I used
> git diff -b), please let me know.

I tend to use -w, to avoid getting reindentations in the diffs. But I 
don't know of any options to make this kind of diff pretty...

// Martin


More information about the FFmpeg-soc mailing list