[FFmpeg-soc] Likely bug in argument error handling of vsrc_movie.c
Brandon Mintern
bmintern at gmail.com
Fri Mar 26 18:35:22 CET 2010
I'm pretty sure from looking at the code that there's a bug here, but
I haven't specifically tried to cause unexpected behavior. Presumably,
the problem is that if no arguments are given to movie, no error will
be reported. Here's my patch:
Index: vsrc_movie.c
===================================================================
--- vsrc_movie.c (revision 5719)
+++ vsrc_movie.c (working copy)
@@ -140,9 +140,8 @@
// sanity check parms
if (mv->seek_point >= 0 && *mv->file_name)
return movie_init(ctx);
- }
- else
- av_log(ctx, AV_LOG_ERROR, "init() expected 3
arguments:'%s'\n", args);
+ }
+ av_log(ctx, AV_LOG_ERROR, "init() expected 3 arguments:'%s'\n", args);
return -1;
}
Brandon
More information about the FFmpeg-soc
mailing list