[FFmpeg-soc] [soc]: r5663 - mms/mmst.c

[Ronald S. Bultje]

Hi,

On Mar 14, 2010, at 8:28 AM, Thilo Borgmann <thilo.borgmann at googlemail.com 
 > wrote:
> Am 14.03.10 13:22, schrieb Thilo Borgmann:
>> Am 14.03.10 12:04, schrieb Michael Niedermayer:
>>> On Sun, Mar 14, 2010 at 11:23:42AM +0100, Thilo Borgmann wrote:
>>>> Am 14.03.10 02:15, schrieb Michael Niedermayer:
>>>>> On Sat, Mar 13, 2010 at 02:40:25PM +0100, Thilo Borgmann wrote:
>>>>>> Am 13.03.10 14:26, schrieb Ronald S. Bultje:
>>>>>>> Hi,
>>>>>>>
>>>>>>> On Mar 13, 2010, at 8:22 AM, Thilo Borgmann
>>>>>>> <thilo.borgmann at googlemail.com> wrote:
>>>>>>>> Am 13.03.10 14:07, schrieb spyfeng:
>>>>>>>>> Author: spyfeng
>>>>>>>>> Date: Sat Mar 13 14:07:31 2010
>>>>>>>>> New Revision: 5663
>>>>>>>>>
>>>>>>>>> Log:
>>>>>>>>> remove "{" and "}" when return -1 directly.
>>>>>>>>
>>>>>>>> My latest news is to always use
>>>>>>>>
>>>>>>>> if () {
>>>>>>>> ...
>>>>>>>> } else {
>>>>>>>> ...
>>>>>>>> }
>>>>>>>>
>>>>>>>> even for one-liners to reduce patch size.
>>>>>>>> Using
>>>>>>>>
>>>>>>>> if () {
>>>>>>>> ...
>>>>>>>> } else
>>>>>>>> ... ;
>>>>>>>>
>>>>>>>> never was a valid choice and AFAIK it still is none.
>>>>>>>
>>>>>>> It reduces codesize by 1 line and is thus better.
>>>>>>>
>>>>>>> More specifically , I asked for it because this MMS patch is  
>>>>>>> seriously
>>>>>>> massively huge and needs some fat trimming.
>>>>>>
>>>>>> I don't want to meddle in here too much and I understand that  
>>>>>> dilemma
>>>>>> but does this reason to avoid common patch rules?
>>>>>
>>>>> which rule?
>>>>
>>>> to use
>>>> if {
>>>> } else {
>>>> }
>>>
>>> where is that rule from? or where is it written?
>>
>> Well IIRC you advised me to use all brackets to reduce future  
>> patches.
>> And not using the mixed form was one of the first things I'd to  
>> change
>> in 2009...
>>
>> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2010-January/081702.html
>
> But maybe "...as the {} cost no extra line in this case..." was the  
> real
> important aspect of it.
>
> And to fix it a little more (at least for me), you actually meant in  
> the
> linked message to use
>
> if() {
> ...;
> } else
> ...;
>
> ? So the mixed style would be ok for SVN?

Yes. :-).

Ronald