[FFmpeg-soc] [soc]: r5663 - mms/mmst.c

[Michael Niedermayer]

On Sat, Mar 13, 2010 at 02:40:25PM +0100, Thilo Borgmann wrote:
> Am 13.03.10 14:26, schrieb Ronald S. Bultje:
> > Hi,
> > 
> > On Mar 13, 2010, at 8:22 AM, Thilo Borgmann
> > <thilo.borgmann at googlemail.com> wrote:
> >> Am 13.03.10 14:07, schrieb spyfeng:
> >>> Author: spyfeng
> >>> Date: Sat Mar 13 14:07:31 2010
> >>> New Revision: 5663
> >>>
> >>> Log:
> >>> remove "{" and "}" when return -1 directly.
> >>
> >> My latest news is to always use
> >>
> >> if () {
> >> ...
> >> } else {
> >> ...
> >> }
> >>
> >> even for one-liners to reduce patch size.
> >> Using
> >>
> >> if () {
> >> ...
> >> } else
> >> ... ;
> >>
> >> never was a valid choice and AFAIK it still is none.
> > 
> > It reduces codesize by 1 line and is thus better.
> > 
> > More specifically , I asked for it because this MMS patch is seriously
> > massively huge and needs some fat trimming.
> 
> I don't want to meddle in here too much and I understand that dilemma
> but does this reason to avoid common patch rules?

which rule?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100314/fa65dc1b/attachment.pgp>