[FFmpeg-soc] [PATCH] fmtp cleanup

[Luca Barbato]

On 06/26/2010 12:28 AM, Josh Allmann wrote:
> Hi,
> 
> This cleans up FMTP parsing code somewhat. I only did it for H.264 and
> MPEG-4/AAC; if this approach is OK, I'll do the rest (Xiph, AMR, etc).
> 
> 0001 -- rtpdec.h is a better place for SPACE_CHARS. Removes a
> dependency on internal.h, and avoids having to #include it in later
> patches.

Fine
> 
> 0002 -- self explanatory. It is likely I will have to change
> value[4096] to be malloc'd due to massive Xiph extradata.

+int ff_parse_fmtp(AVFormatContext *s, int st_index,
+                  void *data, const char *p,
+                  int (*parse_fmtp)(AVFormatContext *s, int st_index,
+                                    PayloadContext *data,
+                                    char *attr, char *value))

Why void data? why AVFormatContext *s, int st_index ? When passing the
stream isn't enough?

+    while (!(res = strspn(p, SPACE_CHARS))) p++; // protocol identifier

are you sure you need that?


> 003-005 -- H.264 related

0003 Ok

0004

-            sdp_parse_fmtp_config_h264(stream, h264_data, attr, value);
-        }
+        return ff_parse_fmtp(s, st_index, h264_data, p,
+                      &sdp_parse_fmtp_config_h264);

sdp_parse_fmtp_config_h264 takes a stream as argument ff_parse_fmtp
parse_fmtp doesn't seem to match the function.

0005 Ok

> 0006-007 -- MPEG-4/AAC related

both Ok

Please check again 0004 =)

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero