[FFmpeg-soc] [PATCH] decouple mpeg4/aac from rtsp

[Josh Allmann]

On 24 June 2010 13:46, Josh Allmann <joshua.allmann at gmail.com> wrote:
> On 24 June 2010 12:53, Luca Barbato <lu_zero at gentoo.org> wrote:
>> On 06/24/2010 10:31 AM, Josh Allmann wrote:
>>> On 24 June 2010 00:14, Martin Storsjö <martin at martin.st> wrote:
>>>>
>>>> Except that, this looks good to me. Ronald, Luca, any other opinions, or
>>>> is this good to go?
>>>>
>>>
>>> Sweeet. Updated patchset is properly numbered.
>>>
>>
>> Two nits
>>
>> 0002
>>
>> + * MPEG-4 Video RTP callbacks.
>>
>> Might be nice adding the rfc number there as well
>>
>
> Added reference to RFC 3016.
>
>> 0004
>>
>> +#include <strings.h>
>>
>> string_s_ ?
>>
>
> Needed for strcasecmp, apparently. Also fixed a related issue;
> strings.h is now included in patch 003 rather than 004.
>

The minor indentation change Martin asked for in 002 somehow
disappeared; patch re-done with this.

> Josh
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Decouple-MPEG-4-and-AAC-specific-parts-from-rtsp.c.patch
Type: text/x-patch
Size: 10639 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100624/58206b06/attachment.bin>