[FFmpeg-soc] [PATCH] RTSP/tunneling: clean up properly on failures

[Josh Allmann]

Hi Martin,

On 18 June 2010 10:57, Martin Storsjö <martin at martin.st> wrote:
> On Fri, 18 Jun 2010, Josh Allmann wrote:
>
>> On 18 June 2010 00:45, Martin Storsjö <martin at martin.st> wrote:
>> > Hi,
>> >
>> > I noticed that the GET URLContext can be leaked if some of the later
>> > operations fail before assigning the handles to rt->rtsp_hd{,_out}. This
>> > patch should fix the issue.
>> >
>> > Josh, do you think this is ok, or would you rather assign the handles
>> > directly to rt->rtsp_hd without using the local variables?
>> >
>>
>> Doesn't the jump to fail: clean things up? If I'm missing something
>> here, then it looks OK.
>
> Applied this fix, feel free to propose other ways to reorganize it to make
> it cleaner (e.g. by assigning the handles directly to rt->rtsp_hd, so the
> normal cleanup path can take care of it.

Thanks for the fix. I do agree that getting rid of the local variables
leads to cleaner code overall, so here's a patch for that.

Josh

>
> // Martin
> _______________________________________________
> FFmpeg-soc mailing list
> FFmpeg-soc at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp-remove-local-variables.diff
Type: text/x-patch
Size: 2766 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100619/dfa1eb9d/attachment.bin>