[FFmpeg-soc] [PATCH] RTSP/tunneling: clean up properly on failures

Josh Allmann joshua.allmann at gmail.com
Fri Jun 18 17:29:41 CEST 2010


Hi Martin,

On 18 June 2010 00:45, Martin Storsjö <martin at martin.st> wrote:
> Hi,
>
> I noticed that the GET URLContext can be leaked if some of the later
> operations fail before assigning the handles to rt->rtsp_hd{,_out}. This
> patch should fix the issue.
>
> Josh, do you think this is ok, or would you rather assign the handles
> directly to rt->rtsp_hd without using the local variables?
>

Doesn't the jump to fail: clean things up? If I'm missing something
here, then it looks OK.

Josh

> // Martin
> _______________________________________________
> FFmpeg-soc mailing list
> FFmpeg-soc at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
>
>


More information about the FFmpeg-soc mailing list