[FFmpeg-soc] [soc]: r5821 - libavfilter/vf_overlay.c

[Baptiste Coudurier]

On 06/09/2010 03:22 PM, Stefano Sabatini wrote:
> On date Friday 2010-06-04 22:15:35 +0200, bcoudurier encoded:
>> Author: bcoudurier
>> Date: Fri Jun  4 22:15:35 2010
>> New Revision: 5821
>>
>> Log:
>> Direct rendering in overlay filter.
>> RGB24 support.
>> Doesn't work with movie in movie yet, needs loop input feature for logos
>> either in movie filter or here.
>
> This broke movie in movie.

Yes, I mentioned this in the commit log :)

> Again, please *don't* make massive changes and introduce regressions
> without not even posting and discussing the changes before, testing
> with ffplay is a bonus.
>
> Consider to fix the regression or revert the patch if you can't do it
> in a reasonable amount of time, or at least try to justify because
> this change should be an improvement over the previous behaviour.

Feel free to revert the commit, that's fine with me.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org