[FFmpeg-soc] [PATCH] rtsp tunneling
Martin Storsjö
martin at martin.st
Wed Jun 9 20:21:36 CEST 2010
On Wed, 9 Jun 2010, Ronald S. Bultje wrote:
> On Wed, Jun 9, 2010 at 5:28 AM, Martin Storsjö <martin at martin.st> wrote:
> > Ronald: There's still an arcitectural regression introduced by the http
> > delay open, that I'm a bit unsure about how to fix. url_fdopen (which is
> > invoked directly by url_fopen) copies the value of is_streamed to the
> > ByteIOContext directly after opening. In the http protocol, is_streamed is
> > 1 initially to indicate that seeking isn't supported, but is set to 0 if a
> > proper reply header is found. This used to be done already within
> > url_open(), but isn't anymore since the connection hasn't been opened yet.
> > So this effectively removes support for seeking in http sources for now.
> >
> > How do you suggest we fix this?
>
> This, and many other regressions, are all caused because URL* combines
> allocation with opening, something that AVFormatContext/AVCodecContext
> separate. The proper thing to do is to separate it also. That breaks
> or adds API, which is bad, but maybe we just have to byte the bullet.
> It also means we have to separate close and free.
>
> Michael, that OK with you, if it doesn't break existing API/apps?
Does adding things to URLContext break the ABI? The external API could be
kept unmodified here - as Ronald said on IRC, we could add individual
functions, like this:
url_open = url_alloc + url_connect
url_close = url_disconnect + url_free
// Martin
More information about the FFmpeg-soc
mailing list