[FFmpeg-soc] [PATCH] rtsp tunneling

[Martin Storsjö]

On Sat, 5 Jun 2010, Ronald S. Bultje wrote:

> How does the caller or callee define the length of the data if it's
> not chunked? We need some defined way of getting that, otherwise this
> will break depending on the receiving server implementation.

If you don't do chunked, you either have to signal it in the 
Content-Length header of the POST, or simply cut the connection when 
you're done. So for normal use of the http protocol in write mode, only 
chunked mode, or no Content-Length header at all would make sense.

For the RTSP HTTP tunneling, the spec suggests a Content-Length with a 
large value, for compatibility with more proxies, though...

> #4 is fine, if Luca is OK (or Martin), please apply.

Yes, this looks fine to me, too. Will apply in a bit if Luca doesn't have 
any objections.

> > +    /** RTSP transport mode, such as plain or tunneled. */
> > +    int mode;
> 
> enum RTSPMode mode. RTSPMode is also a little generic, but I don't
> really have suggestions for a better name. Luca?
> RTSPProtocolConnectionMode?

RTSPSessionMode, RTSPChannelMode, RTSPControlChannelMode are other 
suggestions, but I'm not really sure which one I like the best.

> I think #6 is OK, again Luca/Martin for second review and then it can
> be applied.

This one looks fine to me, too.

// Martin