[FFmpeg-soc] [PATCH] rtsp tunneling

[Josh Allmann]

On 4 June 2010 02:39, Martin Storsjö <martin at martin.st> wrote:
> On Fri, 4 Jun 2010, Josh Allmann wrote:
>
>> On 3 June 2010 07:34, Luca Barbato <lu_zero at gentoo.org> wrote:
>> >
>> > +        if (!av_base64_encode(base64buf, sizeof(base64buf), buf,
>> > strlen(buf))) {
>> > +            av_log(s, AV_LOG_ERROR, "Unable to base64 encode RTSP.\n");
>> > +            return;
>> > +        }
>> >
>> > currently this function assumes that it cannot fail, probably we should
>> > propagate errors.
>> >
>>
>> Done, added a fifth patch for this. I only check and propagate errors
>> within ff_rtsp_send_cmd* functions, but I don't do anything about them
>> when called from other ff_rtsp* functions.
>
> Propagating errors generally is a very good idea. For this particular
> case, the only thing that could fail with base64 is that the output buffer
> isn't large enough, and we already make sure it's large enough. But I'm ok
> with it either way.
>

Fixed that, and other minor errors (s/handler/handle, spelling fixes
in the proper commit, etc). Soc repo has been updated as well.

I am starting another thread that should address the issue of the
subsequent HTTP writes not updating the header.

Josh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Modified-behavior-of-http_open-to-implicitly-delay-c.patch
Type: text/x-patch
Size: 2656 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100605/29b8a6f8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Added-in-capability-to-write-custom-HTTP-headers.patch
Type: text/x-patch
Size: 4721 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100605/29b8a6f8/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Added-support-for-disabling-chunked-transfer-encodin.patch
Type: text/x-patch
Size: 3236 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100605/29b8a6f8/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Adds-in-a-second-RTSP-handle-for-outgoing-messages.patch
Type: text/x-patch
Size: 4392 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100605/29b8a6f8/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Added-in-RTSP-tunneling-over-HTTP.patch
Type: text/x-patch
Size: 6028 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100605/29b8a6f8/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Propagated-errors-up-ff_rtsp_send_cmd.patch
Type: text/x-patch
Size: 5453 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100605/29b8a6f8/attachment-0005.bin>