[FFmpeg-soc] [PATCH] rtsp tunneling
lu_zero at gentoo.org
Thu Jun 3 16:34:50 CEST 2010
On 06/03/2010 12:59 AM, Josh Allmann wrote:
Hi, here some comments, I used your git to checkout* your branch, then I
used git format-patch to have a better look at your changes, here my
Added URL_DELAYOPEN flag to internal api 6322eb07:
+#define URL_DELAYOPEN 4 /* follows URL_* scheme defined in avio.h */
I'm not sure outside programs have no use for it.
@@ -0,0 +1,33 @@
+ * HTTP definitions
+ * Copyright (c) 2002 Fabrice Bellard
Doesn't look right.
Added in capability to write custom HTTP headers. ea2d753ba:
+ unsigned char headers[BUFFER_SIZE];
+void ff_http_set_headers(URLContext *h, const char *headers)
+ HTTPContext *s = h->priv_data;
+ snprintf(s->headers, sizeof(s->headers), "%s", headers);
I'm not completely happy with this, probably a way to set/get them
might be more nice, but that could be done on a later time.
Added support for disabling chunked transfer encoding. 1ee35e509:
Added in RTSP tunneling over HTTP. 2f6e33908:
+ if (!av_base64_encode(base64buf, sizeof(base64buf), buf,
+ av_log(s, AV_LOG_ERROR, "Unable to base64 encode RTSP.\n");
currently this function assumes that it cannot fail, probably we should
+static inline void close_cxn(RTSPState *rt)
It's a nit but I dislike cxn
The rest looks good.
* If you have already your own git tree you can do the following:
# set the remote to just track the rtsp-tunneling branch
git remote add -t rtsp-tunneling j0sh git://github.com/j0sh/ffmpeg-soc.git
# fetch it
git fetch j0sh
git checkout -b rtsp-tunneling j0sh/rtsp-tunneling
now you can use git pull to update it.
More information about the FFmpeg-soc