[FFmpeg-soc] [soc]AMR-WB decoder branch, master, updated.

[Marcelo Galvão Póvoa]

2010/7/30 Marcelo Galvão Póvoa <marspeoplester at gmail.com>:
> On 30 July 2010 03:36, Diego Biurrun <diego at biurrun.de> wrote:
>> On Fri, Jul 30, 2010 at 02:35:21AM -0300, Marcelo Póvoa wrote:
>>>
>>> --- a/libavcodec/amrwbdec.c
>>> +++ b/libavcodec/amrwbdec.c
>>> @@ -73,11 +73,13 @@ typedef struct {
>>>      float                           prev_tr_gain; ///< previous initial gain used by noise enhancer for thresold
>>>
>>>      float samples_az[LP_ORDER + AMRWB_SUBFRAME_SIZE]; ///< lower band samples from synthesis at 12.8kHz
>>> -    float samples_up[UPS_MEM_SIZE + AMRWB_SUBFRAME_SIZE]; ///< lower band samples processed for upsampling at 12.8kHz
>>> +    float samples_up[UPS_MEM_SIZE + AMRWB_SUBFRAME_SIZE]; ///< lower band samples processed for upsampling
>>>      float samples_hb[LP_ORDER_16k + AMRWB_SFR_SIZE_OUT]; ///< higher band samples from synthesis at 16kHz
>>
>> You should vertically align the doxygen comments.  This probably applies
>> to a lot of other places as well.
>>
>
> These lines are too long, so I could not align the comments with the
> adjacent lines. I've now aligned these three by themselves.
>
>>> @@ -1176,6 +1178,39 @@ static void hb_synthesis(AMRWBContext *ctx, int subframe, float *samples,
>>>
>>>  /**
>>> + * Apply to high-band samples a 15th order filter
>>> + * The filter characteristic depends on the given coefficients
>>> + *
>>> + * @param out                 [out] buffer for filtered output
>>> + * @param fir_coef            [in] filter coefficients
>>> + * @param mem                 [in/out] state from last filtering (updated)
>>> + * @param cp_gain             [in] compensation gain (usually the filter gain)
>>> + * @param in                  [in] input speech data (high-band)
>>
>> This is incorrect doxygen syntax.  The [in]/[out] attributes need to
>> directly follow the @param command, i.e. @param[in].  You have the
>> same mistake in other places, fix it everywhere.
>>
>> Doxygen should warn about this.  Please run doxygen and fix all the
>> warnings that doxygen generates.
>>
>
> Doing this modification I am getting new warnings like this:
>
> Warning: argument 'out' of command @param is not found in the argument
> list of decode_isf_indices_36b(uint16_t *ind, float *isf_q, uint8_t
> fr_q)
>

Nevermind, I've misunderstood your message and put the [in] after the
variable name. It's working now.

>>> +    for (i = 0; i < AMRWB_SFR_SIZE_OUT; i++)
>>> +    {
>>
>> Please use K&R style, i.e. place the { on the same line as the
>> for/while/if/do.
>>
>
> Fixed.
>
> --
> Marcelo
>


-- 
Marcelo