[FFmpeg-soc] [PATCH] add sampling handling to theora depacketizer

[Josh Allmann]

On 27 July 2010 13:35, Luca Barbato <lu_zero at gentoo.org> wrote:
> On 07/27/2010 08:20 PM, Josh Allmann wrote:
>> +        } else {
>> +            av_log(codec, AV_LOG_ERROR,
>> +                   "Unsupported pixel format %s\n", attr);
>> +            return AVERROR_INVALIDDATA;
>
> why not return AVERROR_PATCHWELCOME;
>

The 3 formats I added should cover all legal cases. From Section 1 of the spec:

Three different chroma subsampling formats are supported:
   4:2:0, 4:2:2, and 4:4:4.  The Theora I format does not support
   interlaced material, variable frame rates, bit-depths larger than 8
   bits per component, nor alternate color spaces such as RGB or
   arbitrary multi-channel spaces.