[FFmpeg-soc] [soc] libavsequencer [PATCH 01/08] Music module public API header file.

[Vitor Sessak]

On 07/13/2010 10:11 PM, Sebastian Vater wrote:
> Vitor Sessak a écrit :
>> On 07/07/2010 10:46 PM, Sebastian Vater wrote:

[...]

>>> /**
>>>   * Opens and registers module to the AVSequencer.
>>>   *
>>>   * @param avctx the AVSequencerContext to store the opened module into
>>>   * @param module the AVSequencerModule which has been opened to be
>>> registered
>>>   * @return>= 0 on success, a negative error code otherwise
>>>   *
>>>   * @note This is part of the new sequencer API which is still under
>>> construction.
>>>   *       Thus do not use this yet. It may change at any time, do not
>>> expect
>>>   *       ABI compatibility yet!
>>>   */
>>> int avseq_module_open(AVSequencerContext *avctx, AVSequencerModule
>>> *module);
>>
>> Hmm, I think I don't really understand what this function do. Suppose
>> you want to write a very short test program to play a MOD file using
>> the libraries. Roughly, what functions it will call, in which order
>> and with which parameters?
>
> To be honest, I added this prototype only for now to see if the way I
> want to add them is compatible with FFmpeg style guide. Wanted just to
> avoid adding functions and all follow a wrong guideline. But the suppose
> is to load a module from disc and register it to the module list in avctx).

Guideline-wise it is fine, but I don't think functions should be added 
to the BSS structs without a very good reason.

> The loading, of course, is not necessary in FFmpeg, as it will be done
> by the demuxer itself, but the register process. Also this function can
> be called from the user if he loads a module.

If the user wants to load a module, he should call lavf/ api, no?

-Vitor