[FFmpeg-soc] [soc]: r5556 - in indeo5: TODO indeo5.c ivi_common.c ivi_common.h ivi_dsp.c ivi_dsp.h

[Diego Biurrun]

On Sun, Jan 03, 2010 at 02:19:11AM +0100, maximum wrote:
> 
> Log:
> This commit adds a support for the scalability mode. The code still contains several minor bugs but I'm working hard on fixing them.

This sentence tells you that describing what a description will do is
redundant.  Just describe whatever it is that you want to explain.

Also, please break long lines in commit messages, i.e. write them in
an editor.

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ indeo5/ivi_dsp.c	Sun Jan  3 02:19:11 2010	(r5556)
> @@ -0,0 +1,588 @@
> +
> +/**
> + *  5/3 - Wavelet recomposition filter for indeo5.
> + */
> +void ff_ivi_recompose53(const IVIPlaneDesc *plane, uint8_t *dst, const int dst_pitch, const int num_bands)

long line

> +            IVI_INV_SLANT8( in[0],  in[1],  in[2],  in[3],  in[4],  in[5],  in[6],  in[7],
> +                            out[0], out[1], out[2], out[3], out[4], out[5], out[6], out[7]);

Indentation looks off.

> +/**
> + *  8x8 block motion compensation with adding delta.
> + */
> +void ff_ivi_mc_8x8_delta(int16_t *buf, int16_t *ref_buf, uint32_t pitch, int mc_type)
> +{
> +    int     i, j;
> +    int16_t *wptr;
> +
> +    switch (mc_type) {
> +        case 0: /* fullpel (no interpolation) */

K&R places 'case' at the same indentation depth as 'switch', same below.

Diego