[FFmpeg-soc] G.723.1 Encoder: Compute adaptive codebook contribution, obtain residual

[Diego Biurrun]

On Fri, Aug 20, 2010 at 11:58:35AM +0530, Mohamed Naufal wrote:
> 
> --- a/libavcodec/g723_1.c
> +++ b/libavcodec/g723_1.c
> +
> +    if(!odd_frame) {

if (

Please review all your code so that it conforms to K&R style.

> +        if (pitch_lag == PITCH_MIN)
> +            pitch_lag++;
> +        else
> +            pitch_lag = FFMIN(pitch_lag, PITCH_MAX - 5);
> +    }

pointless {}

> +/**
> + * Subtract the adaptive codebook contribution from the input
> + * to obtain the residual.
> + *
> + * @param buf target vector
> + */

This is missing doxygen documentation for the other parameters.  Please
do not add incomplete documentation.  Try running 'doxygen Doxyfile' and
fix all the warnings your code generates.

Diego