[FFmpeg-soc] [soc]: r5911 - mms/mmsh.c

Diego Biurrun diego at biurrun.de
Sat Aug 21 12:42:02 CEST 2010


On Tue, Aug 17, 2010 at 04:46:31PM +0200, spyfeng wrote:
> 
> --- mms/mmsh.c	Tue Aug 17 16:01:15 2010	(r5910)
> +++ mms/mmsh.c	Tue Aug 17 16:46:31 2010	(r5911)
> @@ -262,12 +262,16 @@ static int mmsh_open(URLContext *h, cons
>      for (i = 0; i < mms->stream_num; i++) {
> -        err = snprintf(stream_selection + offset, sizeof(stream_selection) - offset,
> +        err = snprintf(tmp, sizeof(tmp),
>                            "ffff:%d:0 ", mms->streams[i].id);

Indentation is off.  You should align the function arguments vertically:

  err = snprintf(tmp, sizeof(tmp),
                 "ffff:%d:0 ", mms->streams[i].id);

I have seen you do this in many other places, please fix all your code.

Diego


More information about the FFmpeg-soc mailing list