[FFmpeg-soc] [PATCH] RTCP BYE

[Josh Allmann]

On 16 August 2010 07:53, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Mon, Aug 16, 2010 at 10:46 AM, Martin Storsjö <martin at martin.st> wrote:
>> On Mon, 16 Aug 2010, Ronald S. Bultje wrote:
>>> On Mon, Aug 16, 2010 at 10:38 AM, Martin Storsjö <martin at martin.st> wrote:
>>> > Is RDT received over rtp:// URLContexts? If that's the case, this patch
>>> > itself still is ok, you just won't ever get any data on the RTCP socket.
>>>
>>> Yeah, RDT stuff is interleaved within the stream. Kind of ugly, I
>>> guess. TCP has its own mechanism, I'm sure, can you look into that
>>> also?
>>
>> Yeah, I think it should all work just fine. This particular issue was for
>> UDP where the packets are sent on a separate socket, that we need to
>> include in the select(). For TCP they all come in the same stream, and are
>> already properly passed to rtpdec, where the new code would do the right
>> thing.
>
> Right. You'll notice that we do in fact open the socket for RTCP, even
> for RDT streams. So you can just add it. It should just never receive
> any data.
>

I might be missing something, but I don't see any particular RDT
handling code in rtsp_fetch_packet other than rdt_parse_packet. Do I
still need to do something?

Attached patches address all comments so far:

-Add in rtp_get_rtcp_file_handle function, preserving the deprecation
of rtp_get_file_handles

-Counter for the number of BYEs received, which is reset after a seek.
If nb_byes == nb_streams, we return EOF. As mentioned earlier, this is
probably not the correct behavior.

Autoexit does not trip under my tests, perhaps because with this
patch, the EOF never makes it back to ffplay. Instead,
av_read_frame_internal tries to return some (bogus?) final packets
(utils.c:1119).

Josh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Replace-hard-coded-RTCP-packet-types-with-defines.patch
Type: text/x-patch
Size: 4357 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100818/348dfd34/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-rtp_get_rtcp_file_handle-functon.patch
Type: text/x-patch
Size: 1300 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100818/348dfd34/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Read-RTCP-packets-in-RTSP-demuxer.patch
Type: text/x-patch
Size: 2189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100818/348dfd34/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Read-RTCP-compound-packets.patch
Type: text/x-patch
Size: 1611 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100818/348dfd34/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-in-RTCP-BYE-support.patch
Type: text/x-patch
Size: 3023 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100818/348dfd34/attachment-0004.bin>