[FFmpeg-soc] [PATCH] RTCP BYE

[Martin Storsjö]

On Mon, 16 Aug 2010, Ronald S. Bultje wrote:

> On Mon, Aug 16, 2010 at 10:38 AM, Martin Storsjö <martin at martin.st> wrote:
> > Is RDT received over rtp:// URLContexts? If that's the case, this patch
> > itself still is ok, you just won't ever get any data on the RTCP socket.
> 
> Yeah, RDT stuff is interleaved within the stream. Kind of ugly, I
> guess. TCP has its own mechanism, I'm sure, can you look into that
> also?

Yeah, I think it should all work just fine. This particular issue was for 
UDP where the packets are sent on a separate socket, that we need to 
include in the select(). For TCP they all come in the same stream, and are 
already properly passed to rtpdec, where the new code would do the right 
thing.

> > I'm a bit undecided on how to handle this, if we should return EOF when
> > the first stream sends BYE, or only when we've got that on all streams?
> >
> > Josh, does the main servers (DSS, feng) send BYE at eof on all streams at
> > the end? Does DSS send BYE properly on live streams, too?
> >
> > If all send BYE on all streams properly, perhaps we should wait for them
> > all. On the other hand, in normal RTSP at least, all streams exist for the
> > full duration of the stream (I think?), so you don't have to worry about
> > the case when one stream is finished but another one still is playing
> > properly for a longer time.
> 
> Wait-for-all would be better, setting a flag on each RTSPStream (and
> re-setting that flag after a seek) shouldn't be too difficult.

Sounds reasonable.

// Martin