[FFmpeg-soc] [PATCH] RTCP BYE

[Luca Barbato]

On 08/15/2010 10:58 AM, Josh Allmann wrote:
> Hi,
> 
> Here is a first attempt at RTCP BYE support, in bite-size patches.
> 
> 0001 - Replace hardcoded RTCP packet types with an enum.

Ok

> 0002 - Reinstate rtp_get_file_handles function that is slated for
> removal at the next major bump. We need to be able to get the RTCP fd
> from the rtpproto.

Ok

> 0003 - Read RTCP packets from the RTSP demuxer. This might not be
> strictly necessary, but it guarantees we'll read a RTCP packet if one
> is available (without the availability of a RTP data packet).

Ok, maybe you can factorize it a bit better on a later time.

> 0004 - According to RFC 3550, RTCP is always sent in
> compound/aggregate form, starting with either a SR or RR packet, with
> the other types (eg, BYE) following. This patch enables reading past
> the first SR packet.

Ok

> 0005 - Actual BYE support. This is really kinda incomplete. It only
> returns EOF, whereas we should be selectively removing the stream
> (theoretically we could have concurrent streams playing, and one BYEs
> while the others keep going). In the case where we get a BYE with only
> one stream left, perhaps an EOF would be appropriate then.

Not sure when that would happen, seems unlikely enough to not be
considered now.

> Right now, not much happens since the EOF is propagated back to the
> application layer. FFplay pretty much ignores it, although I suppose
> it could (should?) be patched to call av_close_input_stream, so it
> sends a proper TEARDOWN.

Yup, it should do that, I wonder where the eof is lost.

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero