[FFmpeg-soc] [soc] libavsequencer [PATCH 01/08] Music module public API header file.

[Sebastian Vater]

Vitor Sessak a écrit :
> On 08/13/2010 10:45 PM, Sebastian Vater wrote:
>> Vitor Sessak a écrit :
>>> On 08/07/2010 09:42 PM, Sebastian Vater wrote:
>>>
>>>
>>>> +    /** Forced duration of the module, in AV_TIME_BASE fractional
>>>> +       seconds. This is the total sum of all sub-song durations
>>>> +       this module contains or zero if the duration is unknown and
>>>> +       also cannot be automatically determined. The composer then can
>>>> +       set manually a duration after which the player can skip
>>>> over to
>>>> +       the next module if it is playing back in once mode.  */
>>>> +    uint64_t forced_duration;
>>>
>>> This looks like a mix between what we discussed and what it was
>>> before. For me (and you seemed to agree), if the song finishes after
>>> the last note, this field should be set to zero, no matter if the
>>> duration can be automatically determined or not. If the duration _can_
>>> be determined automatically, one should set the corresponding field of
>>> _AVCodecContext_ (obviously, when forced_duration != 0, we can always
>>> determine the song duration and it is equal to forced_duration).
>>
>> Based on your description, we actually mean the same, maybe my
>> documentation is misleading on this,
>
> Yes, why do you mention "contains or zero if the duration is unknown
> and also cannot be automatically determined." if it should contain
> zero if the duration is known (or determined) but not to be enforced
> forcibly?
>
>> do you have an idea to better write it?
>
> Sure:
>
>     /** Forced duration of the module, in AV_TIME_BASE fractional
>        seconds. If non-zero, the song should forcibly end after
>        this duration, even if there are still notes to
>        be played.
>      */
>     uint64_t forced_duration;

Fixed by your suggestions!

-- 

Best regards,
                   :-) Basty/CDGS (-: