[FFmpeg-soc] vp8 de/packetizers

[Josh Allmann]

Hi,

On 12 August 2010 13:15, Martin Storsjö <martin at martin.st> wrote:
> On Thu, 12 Aug 2010, Luca Abeni wrote:
>
>> On 12/08/10 21:56, Martin Storsjö wrote:
>> [...]
>> > > > The packetizer looks good to me now, do you agree, Luca A?
>> > > Sorry, I think I did not receive the patch... I'll have a look at the
>> > > ffmpeg-soc archives.
>> > > Anyway, I think the warning should be printed with av_log() (printing it
>> > > in
>> > > the SDP as a comment might be an idea, but I'd like to see a warning on
>> > > stderr
>> > > too).
>> >
>> > Yeah, it is printed with av_log, he just prints it in sdp.c instead of
>> > adding a separate VP8-specific case in the rtpenc initialization (where
>> > none is needed otherwise).
>> Ah, I see... But I think that adding a VP8 case in rtp_write_header() would be
>> a better idea (for some reason, people might stream VP8 over RTP without
>> calling avf_sdp_create()).
>
> Hmm, good point.
>

Done. I'm not sure whether AV_LOG_WARNING prints to stderr?

>> Also, after reading the patch I think it would be nicer to have rtp_send_vp8()
>> defined in a separate rtpenc_vp8.c file (sorry, I did not read the full
>> archives, so I do not know if this has been discussed before).
>
> No, it hasn't been discussed before - I guess Josh thought it was so short
> that it didn't require a separate file, but if you'd prefer that, I guess
> he can change it that way. :-)
>

Done. It feels a bit unwieldy though -- not only is the function
really short, but the diff now touches rtpenc.h, the Makefile, and
adds another non-static function to the ff_ namespace. My preference
would be to keep it in rtpenc.c, but I'm not maintainer.

Also added the vp8->data check that was requested by Martin earlier.

The proposal also moved to the webm website, so I've updated the
in-code docs accordingly.
http://www.webmproject.org/code/specs/rtp/

Finally, updated the Changelog, bumped micro, and rebased against the
LATM patch so everything should be up to date.

Josh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-RTP-packetization-of-VP8.patch
Type: text/x-patch
Size: 5357 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100813/9b069ea5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-RTP-depacketization-of-VP8.patch
Type: text/x-patch
Size: 8057 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100813/9b069ea5/attachment-0001.bin>