[FFmpeg-soc] vp8 de/packetizers

[Martin Storsjö]

On Thu, 12 Aug 2010, Luca Abeni wrote:

> On 12/08/10 21:56, Martin Storsjö wrote:
> [...]
> > > > The packetizer looks good to me now, do you agree, Luca A?
> > > Sorry, I think I did not receive the patch... I'll have a look at the
> > > ffmpeg-soc archives.
> > > Anyway, I think the warning should be printed with av_log() (printing it
> > > in
> > > the SDP as a comment might be an idea, but I'd like to see a warning on
> > > stderr
> > > too).
> > 
> > Yeah, it is printed with av_log, he just prints it in sdp.c instead of
> > adding a separate VP8-specific case in the rtpenc initialization (where
> > none is needed otherwise).
> Ah, I see... But I think that adding a VP8 case in rtp_write_header() would be
> a better idea (for some reason, people might stream VP8 over RTP without
> calling avf_sdp_create()).

Hmm, good point.

> Also, after reading the patch I think it would be nicer to have rtp_send_vp8()
> defined in a separate rtpenc_vp8.c file (sorry, I did not read the full
> archives, so I do not know if this has been discussed before).

No, it hasn't been discussed before - I guess Josh thought it was so short 
that it didn't require a separate file, but if you'd prefer that, I guess 
he can change it that way. :-)

// Martin