[FFmpeg-soc] [soc] libavsequencer [PATCH 05/08] Instrument handling public API header file.
Sebastian Vater
cdgs.basty at googlemail.com
Sat Aug 7 21:54:06 CEST 2010
Sebastian Vater a écrit :
> Vitor Sessak a écrit :
>
>> On 07/13/2010 11:13 PM, Sebastian Vater wrote:
>>
>>
>>> Original TuComposer didn't even use typedef's at all, the only way to
>>> access them was a struct TuComposerInstrEnvelope, etc.
>>>
>>> I also prefer the way to provide the target programmer more freedom than
>>> shrinking it, despite the fact that writing the header the way I did
>>> doesn't require much amount of time.
>>>
>>> This, however, is just a target-programmer-user-friendly purpose and
>>> wouldn't interfere with player.c by changing that, since I replaced all
>>> struct AVSequencer* with simply AVSequencer*
>>>
>>> However, changing that again, would require extra work by additionally
>>> making it a bit uncomfortable to target programmers. So if you are not
>>> piecy on this, I would keep is it at now, I will leave that decision
>>> completely to you, though. If you want me to remove that, I'll do.
>>>
>> Leave it as is. Maybe it is just my personal taste and not very
>> important ATM.
>>
>
> Ok. Updated patch though.
>
Hi I have excellent news!
libavsequencer now flawlessly integrates into FFmpeg, just check out my
latest git. Please do a git pull --rebase, Stefano had problems without
using it.
Here are the instr.[ch] part of the BSS to review.
This version compiles perfectly.
--
Best regards,
:-) Basty/CDGS (-:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: instr.c_20100807.patch
Type: text/x-patch
Size: 19355 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100807/0d2322ae/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: instr.h_20100807.patch
Type: text/x-patch
Size: 27169 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100807/0d2322ae/attachment-0001.bin>
More information about the FFmpeg-soc
mailing list