[FFmpeg-soc] [soc] libavsequencer [PATCH 01/08] Music module public API header file.

[Sebastian Vater]

Vitor Sessak a écrit :
> On 07/15/2010 09:35 PM, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Thu, Jul 15, 2010 at 3:12 PM, Sebastian Vater
>> <cdgs.basty-gM/Ye1E23mwN+BqQ9rBEUg at public.gmane.org>  wrote:
>>> Just a question for understanding...what's the advantage of using
>>> enum's
>>> then? The only one I see straight away is that there is less space
>>> required (saving 4 characters by replacing '#define ' with '    ').
>>
>> Documentation tools (e.g. doxy) will group them together and treat
>> them as a group of related properties, rather than separate entities.
>> That's a big one for a huge project such as FFmpeg, where in the
>> future many people will look at and modify your code, without
>> necessarily understanding everything at the beginning.
>
> Not to mention having variables of the type "enum Whatever" instead of
> a plain int, which tell immediately which kind of constants should be
> assigned to it.

Hi I have excellent news!

libavsequencer now flawlessly integrates into FFmpeg, just check out my
latest git. Please do a git pull --rebase, Stefano had problems without
using it.

Here are the module.[ch] part of the BSS to review.

This version compiles perfectly.

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: module.c_20100807.patch
Type: text/x-patch
Size: 2391 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100807/87fc2c7d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: module.h_20100807.patch
Type: text/x-patch
Size: 4392 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100807/87fc2c7d/attachment-0001.bin>