[FFmpeg-soc] [PATCH] xiph packetizer

[Martin Storsjö]

On Mon, 2 Aug 2010, Josh Allmann wrote:

> On 29 July 2010 23:48, Martin Storsjö <martin at martin.st> wrote:
> > On Thu, 29 Jul 2010, Josh Allmann wrote:
> >>
> >> http://mirrorblender.top-ix.org/peach/bigbuckbunny_movies/big_buck_bunny_480p_stereo.ogg
> >
> > Hmm, ffplay has some weird issues with this file on OS X, but if hacked to
> > request slightly larger YUV overlay buffers from SDL (with a width being a
> > multiple of 16), it works fine.
> >
> 
> Works well on linux.
> 
> >> >> Using Theora and Vorbis together with RTSP/RTP, things work well.
> >> >> Theora standalone is still full of artifacts around motion with TCP,
> >> >> and UDP is a slideshow because of all the dropped packets. Tomorrow,
> >> >> I'll copy over the packetization routine from Feng and see if the
> >> >> results are more sane.
> >> >
> >> > Hmm, that sounds really strange. Can you give the command lines that
> >> > you've used for these test setups?
> >> >
> >>
> >> ffmpeg -re -i acodec copy -vcodec copy -f rtsp rtsp://localhost/foo.sdp
> >>
> >> also with -an, -vn, and ?tcp variants.
> >>
> >> ffplay rtsp://localhost/foo.sdp
> >
> > Hmm, that's weird, Theora works just fine over TCP for me. Over UDP, I get
> > lots of artefacts due to dropped packets, though, but that's probably to
> > be expected. Tested it with the latest patch you sent (and with the
> > previous one with my local modifications).
> >
> 
> I don't know exactly what I did, but this round adds in support for
> multiple Xiph frames per packet, and the tcp issue is gone. Pebkac
> most likely.

Hmm, weird.

Now I'm getting some issues with vorbis audio with this patch. I'll debug 
it and see what's going wrong in a while - it may just as well be 
something in my setup, but I suspect something with multiple frames per 
packet.

> The r23231 bug with ogg stream copy/Vorbis pts is still there, but
> that's outside the scope of this patch.

Yes, that's out of scope.

// Martin