[FFmpeg-soc] [PATCH] Fix bug in vsrc_movie.c

[Brandon Mintern]

On Thu, Apr 1, 2010 at 2:05 AM, Bobby Bingham <uhmmmm at gmail.com> wrote:
> On Wed, 31 Mar 2010 20:56:41 -0400
> Brandon Mintern <bmintern at gmail.com> wrote:
>
>> I e-mailed this to the list before, but I think it may have been
>> overlooked because I didn't prepend my post with "[PATCH]". When
>> looking at init() in vsrc_movie.c, I noticed that there was an
>> improperly-indented else statement, and looking at the code there
>> appears to be a bug in the error-handling logic. Presumably, when
>> "movie" is called with no args, it will fail without reporting an
>> error. The patch to fix this issue is below.
>>
>> - Brandon
[snip]
> Please attach your patches instead of pasting them inline.  Your mailer
> has mangled the lines.

Sorry about that. For some reason I was under the impression that
mailing list e-mails weren't supposed to have attachments. I thought
it was strange pasting a patch in an e-mail. I'm completely new to
open source contribution, so please forgive my newbie mistakes.

> Also, we require that you separate cosmetic
> changes (changing the indentation on the av_log and "}") and functional
> changes (removing the else) into separate patches.  It makes it easier
> to see what's really changed.
>
> The fix itself looks fine.  Split it up and I'll apply it.
> --
> Bobby Bingham

Fair enough. I've split it into two patches. Both are attached. The
formatting patch should be applied after the bug fix patch (it seemed
sensible to diff it against the bug-fixed version since the formatting
is changed after removing the else).

Brandon

p.s. "Presumably, when 'movie' is called with no args, it will fail
without reporting an error," (as I said initially) is actually
incorrect. The current bug come up when args is present but
poorly-formatted -- it will fail without reporting an error.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vsrc_movie-fix_bug.patch
Type: application/octet-stream
Size: 397 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100401/6d3dc866/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vsrc_movie-fix_formatting.patch
Type: application/octet-stream
Size: 503 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20100401/6d3dc866/attachment-0001.obj>