[FFmpeg-soc] [soc]: r5419 - als/alsdec.c

[Michael Niedermayer]

On Wed, Oct 21, 2009 at 12:33:21PM +0200, Thilo Borgmann wrote:
> Michael Niedermayer schrieb:
> > On Tue, Oct 20, 2009 at 03:00:40PM +0200, thilo.borgmann wrote:
> >> Author: thilo.borgmann
> >> Date: Tue Oct 20 15:00:40 2009
> >> New Revision: 5419
> >>
> >> Log:
> >> Splits reading of block data and decoding of block data.
> >> Introduces ALSBlockData struct.
> > 
> > You are missing the "why" part, that should be explained in the commit
> > message
> 
> Yes, sorry.
> 
> > also this needs a benchmark as there are many additional dereferences
> > added
> 
> It is a necessary evil to support MCC. If it would be faster the "old"
> way for non-MCC files, would this reason to have both, a split read &
> decode function pair and an all-in-one function?

I think a benchmark is usefull to judge if we should spend time thinking
about alternatives to the many dereferences or not

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20091021/e137f7f2/attachment.pgp>