[FFmpeg-soc] [PATCH]aacsbr: rounding

Alex Converse alex.converse at gmail.com
Fri Nov 20 21:35:45 CET 2009


On Wed, Nov 18, 2009 at 6:50 AM, Robert Swain <robert.swain at gmail.com>wrote:

> On Wed, 2009-11-18 at 05:24 -0500, Alex Converse wrote:
> > NINT as specified in 14496-3 is round away from zero which corresponds
> > to lroundf not lrintf. I looked at all the places where it could
> > actually affect the result and I found two places but it might be
> > better to change them all to be safe. Thoughts?
>
> I'm generally inclined to do what the spec says unless we can prove it
> has no effect and alternatives are faster/cleaner or real world
> implementations do something different that is somehow better...?
>
> You can apply these two now and ignore it if you're confident there will
> be no alteration in other cases.
>
>
Applied for all cases.


More information about the FFmpeg-soc mailing list