[FFmpeg-soc] [soc]: r4346 - in wmapro: wma3.h wma3dec.c

[Reimar Döffinger]

On Sun, May 31, 2009 at 10:32:55AM +0200, Sascha Sommer wrote:
> Hi,
> 
> On Samstag, 30. Mai 2009, Benjamin Larsson wrote:
> > faust3 wrote:
> > > Author: faust3
> > > Date: Sat May 30 22:36:24 2009
> > > New Revision: 4346
> > >
> > > Log:
> > > use a sine table when calculating the decorrelation matrix
> > >
> > > Modified:
> > >    wmapro/wma3.h
> > >    wmapro/wma3dec.c
> > >
> > > Modified: wmapro/wma3.h
> > > =========================================================================
> > >===== --- wmapro/wma3.h	Sat May 30 21:22:28 2009	(r4345)
> > > +++ wmapro/wma3.h	Sat May 30 22:36:24 2009	(r4346)
> > > @@ -93,6 +93,7 @@ typedef struct WMA3DecodeContext {
> > >      MDCTContext      mdct_ctx[BLOCK_NB_SIZES];      ///< MDCT context
> > > per block size DECLARE_ALIGNED_16(float, tmp[BLOCK_MAX_SIZE]); ///< imdct
> > > output buffer float*           windows[BLOCK_NB_SIZES];       ///< window
> > > per block size +    float            sin64[33];                     ///<
> > > sinus table for decorrelation
> >
> > Maybe add a static table instead? Then 2 instances would share the table.
> >
> 
> Is this a needed requirement? After reading the discussion from r18681, I'm 
> not sure.

Since it's only slightly above 100 bytes per context IMO no. It might
still be a bit nicer though for users who decode many streams at once.