[FFmpeg-soc] [soc]: r4307 - in als: README alsdec.c

Diego Biurrun diego at biurrun.de
Sun May 24 21:19:55 CEST 2009


On Sun, May 24, 2009 at 09:04:21PM +0200, thilo.borgmann wrote:
> 
> Log:
> Minor changes duo to review.

duE

But this is a bad commit message.  It conveys no useful information.

> Modified:
>    als/README
>    als/alsdec.c

You mix multiple different into one commit.  Bad.

> --- als/alsdec.c	Sun May 24 16:49:10 2009	(r4306)
> +++ als/alsdec.c	Sun May 24 21:04:20 2009	(r4307)
> @@ -33,25 +33,28 @@ typedef struct {
>  
> -static int als_decode_frame(AVCodecContext *avctx,
> +static av_cold int decode_frame(AVCodecContext *avctx,
>                              void *data, int *data_size,
> -                            AVPacket *avpkt) {
> +                            AVPacket *avpkt)

Indentation should be fixed.


Dropping the als function prefix requires changes to the AVCodec
declaration.

Diego


More information about the FFmpeg-soc mailing list