[FFmpeg-soc] [soc]: r4305 - in als: README alsdec.c ffmpeg-patches ffmpeg-patches/addALSdecoder.rev2.patch

[Diego Biurrun]

On Sun, May 24, 2009 at 03:22:14AM +0200, thilo.borgmann wrote:
> 
> Log:
> Initial commit.

It's good that you start early.

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ als/README	Sun May 24 03:22:14 2009	(r4305)
> @@ -0,0 +1,11 @@
> +MPEG-4 ALS DECODER
> +==================
> +
> +Author: Thilo Borgmann <thilo.borgmann at googlemail.com>
> +Mentor: Justin Ruggles <justin.ruggles at gmail.com>
> +
> +This decoder is a project of the Google Summer of Code program 2009.
> +
> +Abstract: The MPEG-4 ALS codec exists quite a while. As FFmpeg lacks support for that, this project aims to include basic decoding functionality to the FFmpeg libraries.

Please keep line length below 80 characters where reasonably possible.

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ als/alsdec.c	Sun May 24 03:22:14 2009	(r4305)
> @@ -0,0 +1,70 @@
> +
> +/** Decode an ALS frame.

Michael likes Doxygen comments in the third person, same below.

> +static int als_decode_frame(AVCodecContext *avctx,
> +                            void *data, int *data_size,
> +                            AVPacket *avpkt) {

K&R coding style please, i.e. put the { on the next line for function
declarations.

> +static int als_decode_init(AVCodecContext *avctx) {

Init functions should be av_cold.

> +static int als_decode_end(AVCodecContext *avctx) {

The als prefix for static functions is pointless.

Diego