[FFmpeg-soc] [soc]: r4241 - in concat: 0001-added-concatenation-option.patch 0002-removed-superfluous-fflush.patch 0003-removed-color-table-check.patch 0004-added-extradata-handling.patch 0005-more-code-cleanup...

[Diego Biurrun]

I'm very disappointed to see a qualified SoC student top-post...

On Thu, Apr 30, 2009 at 05:14:33PM -0400, Geza Kovacs wrote:
> 
> On Tue, Apr 28, 2009 at 7:28 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Mon, Apr 27, 2009 at 11:03:24AM +0200, gkovacs wrote:
> >>
> >> Added:
> >>    concat/0001-added-concatenation-option.patch
> >>    concat/0002-removed-superfluous-fflush.patch
> >>    concat/0003-removed-color-table-check.patch
> >>    concat/0004-added-extradata-handling.patch
> >>    concat/0005-more-code-cleanup.patch
> >>    concat/0006-code-formatting-fixes.patch
> >>    concat/0007-attempting-same-format-concatenation-to-single-strea.patch
> >
> > You add some code and then you need another patch that fixes up its
> > formatting?  This is wrong.
> >
> Sorry, that's just how the commits are in my local git branch; that is
> the verbatim output of git format-patch, and is there merely as backup
> as I can't mirror the entire tree. I don't aim to merge in these
> patches verbatim (by the time I'm done I'll have rewritten half this
> code anyhow); rather I'll let git merge, rebase, and squash them into
> a single patch once I reach a reasonable milestone which can cleanly
> be applied upstream, at which time I'll notify the mailing list;
> please ignore the files in my branch for now.

No, this is not how SoC development is supposed to work.  The Subversion
repositories are not trashcans or webspace that you can use as backup.
Code you commit to it is supposed to be for general review and of
reasonable quality.

If you need offsite backups, upload a tarball to incoming if need be,
but don't misuse the SoC repository.

Diego