[FFmpeg-soc] [soc]: r4250 - wmapro/wma3dec.c

[Michael Niedermayer]

On Fri, May 01, 2009 at 02:17:35PM +0200, faust3 wrote:
> Author: faust3
> Date: Fri May  1 14:17:35 2009
> New Revision: 4250
> 
> Log:
> removed unneeded division
> 
> Modified:
>    wmapro/wma3dec.c
> 
> Modified: wmapro/wma3dec.c
> ==============================================================================
> --- wmapro/wma3dec.c	Fri May  1 13:27:16 2009	(r4249)
> +++ wmapro/wma3dec.c	Fri May  1 14:17:35 2009	(r4250)
> @@ -1007,10 +1007,8 @@ static void wma_inverse_channel_transfor
>                      }
>                  }else{
>                      for(y=s->cur_sfb_offsets[b];y<FFMIN(s->cur_sfb_offsets[b+1], s->subframe_len);y++){
> -                        s->channel[0].coeffs[y] *= 362;
> -                        s->channel[0].coeffs[y] /= 256;
> -                        s->channel[1].coeffs[y] *= 362;
> -                        s->channel[1].coeffs[y] /= 256;
> +                        s->channel[0].coeffs[y] *= 1.4140625f;
> +                        s->channel[1].coeffs[y] *= 1.4140625f;

*= 181.0 / 128;
might be clearer
in that respect, this is really 181/128 and not sqrt(2) ?
Its strange as its floats ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20090501/ffb3b2b3/attachment.pgp>